Autocomplete fallback #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenic
force-pushed
the
autocomplete-fallback
branch
2 times, most recently
from
c8281b7 to
2bf4e9c
Compare
frenic
force-pushed
the
async-everything
branch
from
e0288a7 to
e6286eb
Compare
frenic
force-pushed
the
autocomplete-fallback
branch
from
2ba1cb3 to
b0ef126
Compare
frenic
force-pushed
the
autocomplete-fallback
branch
from
b0ef126 to
172d690
Compare
|
I guess this should be safe since |
This was referenced Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with autocomplete having
| stringwith string literals seems to work just perfectly in VSCode just by replacingstringandnumberwith(string & {})/(number & {}). Suggested in #73.But is this "hack" safe? Is it really this easy? We need to be sure that Typescript won't give us a type error when some compile options are enabled or they fix a bug that suddenly breaks the hack.
Fixes #8 #73