fix: warn when CSP nonce is missing despite useNonce config#3863
Open
SisyphusZheng wants to merge 1 commit into
Open
fix: warn when CSP nonce is missing despite useNonce config#3863SisyphusZheng wants to merge 1 commit into
SisyphusZheng wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
useNonce: trueis configured in the CSP middleware but the response handler usesctx.html()/ctx.json()instead ofctx.render(), the nonce is absent and the CSP silently falls back tounsafe-inlinewith zero indication to the developer.Add a
console.warnwhen this happens so developers are aware their CSP is weaker than expected.Closes #3859