[FS-182355]: Implement logging and use v2 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartik-ganesh
requested review from
ashutosh-dwivedi-e3502,
Surabhi-Ojha and
saurav-chakravorty
kartik-ganesh
changed the title
ashutosh-dwivedi-e3502
suggested changes
Aug 28, 2024
ashutosh-dwivedi-e3502
suggested changes
Aug 28, 2024
# Conflicts: # libs/infinity_emb/infinity_emb/log_handler.py
ashutosh-dwivedi-e3502
approved these changes
Sep 3, 2024
ashutosh-dwivedi-e3502
approved these changes
Sep 3, 2024
Surabhi-Ojha
reviewed
Sep 3, 2024
Surabhi-Ojha
reviewed
Sep 3, 2024
Surabhi-Ojha
reviewed
Sep 3, 2024
Surabhi-Ojha
reviewed
Sep 3, 2024
Surabhi-Ojha
reviewed
Sep 3, 2024
Surabhi-Ojha
reviewed
Sep 3, 2024
Surabhi-Ojha
reviewed
Sep 9, 2024
| @@ -220,13 +225,13 @@ async def _embeddings(data: OpenAIEmbeddingInput): | |||
| if isinstance(data.input, str): | |||
| data.input = [data.input] | |||
|
|
|||
| logger.debug("[📝] Received request with %s inputs ", len(data.input)) | |||
| logger.info("[📝] Received request with %s inputs ", len(data.input)) | |||
There was a problem hiding this comment.
I have kept it unchanged from upstream. Do you foresee any issues due to this?
Surabhi-Ojha
reviewed
Sep 9, 2024
Surabhi-Ojha
reviewed
Sep 9, 2024
Surabhi-Ojha
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.