Backport promotion code batch fix from Solidus #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport Solidus PR 5383 with PR description: When a new promotion with 2.5m new promo codes has created, it just generated about 250k promo codes and then stopped. The PromotionBatch screen this error: Errored: #<ActiveRecord::RecordInvalid: Validation failed: Value has already been taken> This PR rescues the exception raised by the Spree::PromotionCode creation and jumps to the next code to save, avoiding stopping the process completely. The PR also adds the ability to restart the PromotionCodeBatch from the latest PromotionCodes created. Co-Authored-By: Daniele Palombo
mamhoff
added a commit
that referenced
this pull request
Jul 1, 2024
Backport promotion code batch fix from Solidus
mamhoff
added a commit
that referenced
this pull request
Oct 25, 2024
Backport promotion code batch fix from Solidus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport Solidus PR 5383 with PR description:
When a new promotion with 2.5m new promo codes has created, it just generated about 250k promo codes and then stopped.
The PromotionBatch screen this error: Errored: #<ActiveRecord::RecordInvalid: Validation failed: Value has already been taken>
This PR rescues the exception raised by the Spree::PromotionCode creation and jumps to the next code to save, avoiding stopping the process completely. The PR also adds the ability to restart the PromotionCodeBatch from the latest PromotionCodes created.
Cf solidusio/solidus#5383