Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade pnpm lockfile to v9 #10

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

qbtf
Copy link
Contributor

@qbtf qbtf commented Oct 21, 2024

Summary

When trying to build the project, I noticed that my pnpm v8 could not resolve the lock file with:

Ignoring broken lockfile at ... Lockfile not compatible with current pnpm

This patch upgrades the lock file in two steps, one to lockfile v6, and the other to v9. Nx can also understand this new schema.

Ticket(s)

N/A

Type of change

Please delete options that are not relevant.

  • Refactor (no functionality changes)

Screenshot(s)

Test Steps

Reference Document(s)

The lockfile version 5.4 is unsupported by pnpm: pnpm/4.
nx's support: nx#22906.

Checklist

  • Remove unnecessary console or comment
  • Add unit tests

@qbtf qbtf force-pushed the chore/upgrade-pnpm-lockfile-to-v9 branch from ce1fb93 to 3ce833f Compare October 22, 2024 05:24
@qbtf
Copy link
Contributor Author

qbtf commented Oct 22, 2024

This PR has been force-pushed to account for the recent release in the main branch, including removing two package-lock.json.

@qbtf qbtf marked this pull request as ready for review October 22, 2024 05:29
@qbtf qbtf merged commit 46e7c0f into main Oct 23, 2024
@qbtf qbtf deleted the chore/upgrade-pnpm-lockfile-to-v9 branch October 23, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants