🐛 Fix E2E tests and semver validation error type #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #231. Node 14 doesn't seem to accept
undefinedasdataarg tofs.writeFileSync(), so let's just pass an empty string.Moreover, the last E2E test ("generate changelog > update > should display an error if requested version isn't semver") expects an error to be logged when passed a non-semver
releaseoption. However the CLI throws a genericErrorin these cases, which are eventually intercepted by the issue reporter instead of being logged:https://github.com/fredericbonnet/gitmoji-changelog/blob/4a293caece43a953940ed7d753387c41f5df33ab/packages/gitmoji-changelog-cli/src/cli.js#L105-L128
I don't think that's the intended behavior, so the fix is to throw a
FunctionalErrorinstead.Happy Hacktoberfest! 🎃