Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility updates #120

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Accessibility updates #120

wants to merge 4 commits into from

Conversation

blueocto
Copy link

Off the back of this Issue raised: #53

I've ran it through aXe and made some suggested updates.

@blueocto
Copy link
Author

blueocto commented May 6, 2020

Hey y'all, just wondering if you were reviewing these PR's :-) @anasnakawa @artsmc @dungphanxuan @uzumaxy @xtranophilist

Mostafa-Yusuf
Mostafa-Yusuf approved these changes Sep 29, 2021
View reviewed changes
Copy link

@Mostafa-Yusuf Mostafa-Yusuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding language attribute to the HTML element and using the

HTML element to represent the dominant content of the of a document is a good practice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mostafa-Yusuf Mostafa-Yusuf Mostafa-Yusuf approved these changes

@momin-riyadh momin-riyadh momin-riyadh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blueocto @momin-riyadh @Mostafa-Yusuf