Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump jsdom from 25.0.1 to 26.0.0 #674

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 10, 2025

Bumps jsdom from 25.0.1 to 26.0.0.

Release notes

Sourced from jsdom's releases.

Version 26.0.0

Breaking change: canvas peer dependency requirement has been upgraded from v2 to v3. (sebastianwachter)

Other changes:

  • Added AbortSignal.any(). (jdbevan)
  • Added initial support for form-associated custom elements, in particular making them labelable and supporting the ElementInternals labels property. The form-associated callbacks are not yet supported. (hesxenon)
  • Updated whatwg-url, adding support for URL.parse().
  • Updated cssstyle and rrweb-cssom, to improve CSS parsing capabilities.
  • Updated nwsapi, improving CSS selector matching.
  • Updated parse5, fixing a bug around <noframes> elements and HTML entity decoding.
  • Fixed JSDOM.fromURL() to properly reject the returned promise if the server redirects to an invalid URL, instead of causing an uncaught exception.
Changelog

Sourced from jsdom's changelog.

26.0.0

Breaking change: canvas peer dependency requirement has been upgraded from v2 to v3. (sebastianwachter)

Other changes:

  • Added AbortSignal.any(). (jdbevan)
  • Added initial support for form-associated custom elements, in particular making them labelable and supporting the ElementInternals labels property. The form-associated callbacks are not yet supported. (hesxenon)
  • Updated whatwg-url, adding support for URL.parse().
  • Updated cssstyle and rrweb-cssom, to improve CSS parsing capabilities.
  • Updated nwsapi, improving CSS selector matching.
  • Updated parse5, fixing a bug around <noframes> elements and HTML entity decoding.
  • Fixed JSDOM.fromURL() to properly reject the returned promise if the server redirects to an invalid URL, instead of causing an uncaught exception.
Commits
  • 3644055 Version 26.0.0
  • 8ebaee9 Update dependencies and dev dependencies
  • 5984ace Catch invalid redirect URLs
  • d5abcd1 Make querySelectorAll follow the always-impl rule
  • 56f27c2 Add support for ElementInternals's labels property
  • 854ae1b Implement AbortSignal.any()
  • 7cc3500 Update optional peer dependency canvas to v3
  • 8955c99 Add support for canvas v3
  • 8dfe288 Add Node 22 to CI test matrix
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by Sourcery

Build:

  • Bump jsdom dependency to version 26.0.0.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 10, 2025
@auto-assign auto-assign bot requested a review from philipbrembeck January 10, 2025 03:49
Copy link

stackblitz bot commented Jan 10, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

sourcery-ai bot commented Jan 10, 2025

Reviewer's Guide by Sourcery

This PR bumps the jsdom dependency from version 25.0.1 to 26.0.0. The upgrade includes a breaking change, requiring canvas v3 instead of v2. Several other dependencies are updated as well, resulting in improved CSS parsing, selector matching, and HTML entity decoding. A bug in JSDOM.fromURL() is also fixed.

Sequence diagram showing fixed JSDOM.fromURL() behavior

sequenceDiagram
    participant Client
    participant JSDOM
    participant Server
    Client->>JSDOM: fromURL(url)
    JSDOM->>Server: HTTP Request
    alt Valid Redirect
        Server-->>JSDOM: 3xx Redirect
        JSDOM->>Server: Follow Redirect
        Server-->>JSDOM: 200 OK
        JSDOM-->>Client: Resolved Promise
    else Invalid Redirect URL
        Server-->>JSDOM: 3xx Redirect (invalid URL)
        Note right of JSDOM: Previously: Uncaught Exception
        Note right of JSDOM: Now: Proper Promise Rejection
        JSDOM-->>Client: Rejected Promise
    end
Loading

Class diagram showing updated JSDOM dependencies

classDiagram
    class JSDOM {
        +fromURL()
    }
    class Canvas {
        <<peer dependency>>
        version: v3
    }
    class Dependencies {
        cssstyle: 4.2.1
        whatwg-url: 14.1.0
        parse5: 7.2.1
        nwsapi: 2.2.16
        rrweb-cssom: 0.8.0
    }
    JSDOM --> Canvas : requires
    JSDOM --> Dependencies : uses
    note for Canvas "Breaking change: Upgraded from v2 to v3"
    note for Dependencies "Updated for improved parsing and matching"
Loading

File-Level Changes

Change Details Files
Upgrade jsdom from v25 to v26
  • Updated the jsdom dependency to ^26.0.0 in package.json
  • Updated the jsdom dependency and its sub-dependencies to v26 in pnpm-lock.yaml
  • Updated the canvas peer dependency to v3
package.json
pnpm-lock.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, dependabot[bot]!). We assume it knows what it's doing!

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/jsdom-26.0.0 branch from 7e23542 to 58498f6 Compare January 13, 2025 03:39
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/jsdom-26.0.0 branch from 58498f6 to f4c7199 Compare January 21, 2025 03:43
Bumps [jsdom](https://github.com/jsdom/jsdom) from 25.0.1 to 26.0.0.
- [Release notes](https://github.com/jsdom/jsdom/releases)
- [Changelog](https://github.com/jsdom/jsdom/blob/main/Changelog.md)
- [Commits](jsdom/jsdom@25.0.1...26.0.0)

---
updated-dependencies:
- dependency-name: jsdom
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/jsdom-26.0.0 branch from f4c7199 to d2ec383 Compare January 28, 2025 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant