Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Adjustment #382

Closed
wants to merge 1 commit into from
Closed

WIP: Adjustment #382

wants to merge 1 commit into from

Conversation

davidwessman
Copy link
Member

Addresses #230.

  • Change adjustment page to look for exact matches.
  • Adds keyboard shortcuts to make adjustment faster.
  • Allow partial searches of card-numbers on vote_users pages.

@navro
Copy link
Member

navro commented Apr 1, 2018

Wow, nice to have shortcuts!

@JohanWinther
Copy link

Is it possible to automatically send users a new vote code upon adjustment?
People usually can't find their old vote code from the previous meeting which makes it easier to just send a new one when they arrive.

And also my vision with the quick adjustment is to just have a computer with the card reader in the room and then people can swipe their card and get a confirmation on the screen with their name. That is nobody needs to touch any button or confirm their adjustment, it just happens. For extra security somebody can check the card validity before they are swiping. Maybe it's better to name this user friendly page as "Automatic adjustments" or something along those lines?

@JohanWinther
Copy link

I managed to create my desired functionality with a really hacky solution (check out my shortcuts.js and card.js.erb).

In short, whenever a user is searched at the quick adjustments page the adjust button is automatically clicked and the information is sent to a new window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants