Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure R plugin for RProvider v2 #538

Merged
merged 6 commits into from
Nov 3, 2021
Merged

Conversation

AndrewIOM
Copy link
Collaborator

RProvider v2 is compiled for .NET 5 and greater - a fix has just been applied to re-enable plugins.
Addresses #526

I have reconfigured the Deedle RProvider plugin to work with this latest RProvider version, compiled against net-5.0. This has been tested on a local RProvider source - the nuget package for this will shortly be updated. At that stage, I will reference it from here and remove the draft mark from this PR.

Screenshot 2021-10-22 at 17 21 56

@AndrewIOM AndrewIOM marked this pull request as ready for review October 22, 2021 17:57
- R is already installed on ubuntu-latest
- Using the action for some reason causes an infinite hang on RProvider builds
@zyzhu
Copy link
Contributor

zyzhu commented Nov 3, 2021

Awesome work. I've tested locally and it works like a charm. I'll merge this and clean up the build script and release a new version referencing RProvider 2.0.1. Or shall I wait till you release a newer version 2.0.2? I saw there are some breaking changes coming in the latest pull requests in RProvider.

@zyzhu zyzhu merged commit e6fea7c into fslaborg:master Nov 3, 2021
@AndrewIOM
Copy link
Collaborator Author

@zyzhu Great! I've just pushed a version 2.0.2 incorporating the breaking change so you can change the RProvider version to that in Deedle. I noticed I missed a change in the push-master.yml. Changing this

      - name: Set R_HOME (for RProvider)
        run: echo "R_HOME=$(R RHOME)" >> "$GITHUB_ENV"
        shell: bash

to this

      - name: Set R environment variables (for RProvider)
        run:  |
          mkdir -p ~/.local/lib/R
          echo "R_LIBS_USER=~/.local/lib/R" >> "$GITHUB_ENV"
          echo "R_HOME=$(R RHOME)" >> "$GITHUB_ENV"

should fix the build error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants