Daily Perf Improver - Enable additional vector benchmarks #16
+13
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables three previously commented-out vector benchmarks as part of Phase 1 (Quick Wins) of the performance improvement plan. This expands benchmark coverage to measure performance of additional core vector operations.
Performance Goal
Goal Selected: Expand benchmark coverage for all vector operations (Phase 1, Priority: HIGH)
Rationale: The research identified that many important operations (multiply, dot product, norm) were commented out in the benchmark suite. Having comprehensive benchmarks is essential for:
Changes Made
Enabled Benchmarks
Files Modified
benchmarks/FsMath.Benchmarks/Vector.fs
- Uncommented three benchmark methodsbuild.sh
- Made executable (required by build steps)Approach
Vector.multiply
,Vector.dot
,Vector.norm
)--job short
Performance Measurements
Test Environment
Results Summary
Key Observations
Detailed Results
Replicating the Performance Measurements
To replicate these benchmarks:
Testing
✅ All benchmarks compile successfully
✅ All benchmarks can be discovered via
--list flat
✅ All benchmarks execute without errors
✅ Existing tests still pass (132 tests passed)
Next Steps
This PR establishes comprehensive baseline measurements for vector operations. Future work from the performance plan includes:
Related Issues/Discussions
🤖 Generated with Claude Code