Add support for Artifactory by using the SearchQueryService as a fallback when AllVersionsAPI is not available #4303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is not available (for enabling Artifactory support)
|
@forki this PR will allow us to use Paket which will enable us to use Bazel builds with our internal Artifactory instance; massively valuable. Could it be merged please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #3638 . Using the advice from this helpful comment #3638 (comment) this PR changes the logic to attempt to use the regular AllVersionsAPI but will fall back to the SearchQueryService (which is the only option available in Artifactory). I have tested this against a local Artifactory instance across different types of NuGet packages (eg prereleases) and appears to work correctly.