Allow file mode="x" with get_fs_token_paths #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am fine with this, but ... mode x isn't actually enforced on remote filesystems. On local, the mode is passed on to the OS so you get the expected behaviour. Is this a problem? |
|
It's a problem for dask users using the default local cluster. Here is Hendrik explaining how he can't save a dataframe to csv using mode="x", where mode="w" works well: dask/dask#10442 |
|
Yes, but my point is that this will probably fail anyway on, for example, gcs. Either way, expand should do the right thing, so this change is worthwhile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1332
Related: dask/dask#10442
fsspec does not always behave correctly when file mode="x" is used. This PR addresses one particular instance that is causing flow-on problems for dask.