Add bulk_mkdirs #1592
Add bulk_mkdirs #1592
Conversation
| @@ -306,6 +306,9 @@ def makedirs(self, path, exist_ok=False): | |||
| """ | |||
| pass # not necessary to implement, may not have directories | |||
|
|
|||
| def bulk_makedirs(self, path, **kw): | |||
There was a problem hiding this comment.
Why do we need a special function here instead of modifying the makedirs function?
There was a problem hiding this comment.
I had imagined it like cp/cp_file
There was a problem hiding this comment.
Why can't we just override makedirs to no check if the dirrectory exists for object stores since we directories aren't really a concept there?
There was a problem hiding this comment.
_makedirs is overidden by implementations already, so every implementation would have to make the list-of-paths check or do some sort of super()
There was a problem hiding this comment.
I am still confused is this suppose to overridden by the implementation? Are there are implementations that override it currently?
There was a problem hiding this comment.
No there are none, but s3fs would be the first, since we don't want to check the existence of every directory, only the root bucket, or try to make the bucket multiple times.
There was a problem hiding this comment.
If you can think of a simpler way to do it, happy to hear!
No description provided.