Create warning for appending mode 'a' operations#675
Merged
martindurant merged 3 commits intofsspec:mainfrom May 20, 2025
Merged
Create warning for appending mode 'a' operations#675martindurant merged 3 commits intofsspec:mainfrom
martindurant merged 3 commits intofsspec:mainfrom
Conversation
martindurant
reviewed
May 7, 2025
Member
martindurant
left a comment
There was a problem hiding this comment.
Thanks for the suggestion - it is reasonable.
I wonder whether someone would like to try to implement append mode via compose , i.e., write new data to a temporary file and then join the parts.
For small initial files (< block_size), they can simply be read and re-written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add specific warning for files in appending mode since gcsfs ignores
mode='a'as stated in issue #533.