Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lollipop Horizontal Chart - refactor #196

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Lollipop Horizontal Chart - refactor #196

wants to merge 2 commits into from

Conversation

ajwl
Copy link
Contributor

@ajwl ajwl commented Apr 7, 2017

  • Refactor chart in new style
  • Remove dependencies from inside the directory
  • Extract some configuration to the top of the index file

NEED TO CHECK:
Padding / margins - what's our policy on adding margins to the webframe? Currently we need to, do we plan to make these more

screen shot 2017-04-07 at 12 39 22

screen shot 2017-04-07 at 12 39 39

@ajwl
Copy link
Contributor Author

ajwl commented Apr 7, 2017

@tomgp - would be good if you can take a look when you're back
Prob worth waiting to see how we can use @bobhaslett 's magical yLabel spacing function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ajwl