Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Seeder, views, and migrations for consistency #28

Merged
merged 8 commits into from
Feb 8, 2025

Conversation

thejmitchener
Copy link
Member

@thejmitchener thejmitchener commented Feb 8, 2025

Pull Request Description: Refactor: Seeder, Views, and Migrations for Consistency

This pull request introduces significant refactoring across several components of the project, including the seeder, migrations, and views, to enhance consistency and maintainability.

Motivation for the Change

  1. Improved Naming Conventions:

    • The renaming of the image field to feature_image in the migration aligns better with common practices and improves clarity about its purpose.
    • The seeder class has been renamed from PagesTableSeeder to PageTableSeeder to maintain singular naming conventions, thereby enhancing readability and consistency across the codebase.
  2. Standardized View Components:

    • The updates in the Blade templates ensure a more consistent application of classes and attributes. This includes unifying the text color for better contrast and accessibility, which enhances the user experience.
  3. Enhanced Factory Usage:

    • The introduction of the PageFactory allows for easier and more flexible generation of test data, which is crucial for maintaining robust unit tests and ensuring accurate database interactions.
  4. SEO Improvements:

    • The refactoring improves the way SEO data is passed to views, using a more streamlined approach that reduces redundancy and enhances performance.

Benefits to the Project

  • Consistency: By standardizing naming conventions and practices across the project, we reduce cognitive load for developers and make it easier to navigate the codebase.
  • Maintainability: Cleaner and more consistent code is easier to maintain and extend, facilitating future development efforts.
  • Improved Readability: Clearer naming and structured views enhance the readability of the code, making it easier for new contributors to onboard and understand the existing architecture.
  • Enhanced Performance: Optimized view handling can lead to better performance in rendering and serving pages, which is crucial for user experience.

Overall, these changes are aimed at fostering a more organized and efficient codebase, ultimately leading to a more robust and scalable application.

thejmitchener and others added 5 commits February 8, 2025 14:30
Replaced `PagesTableSeeder` with `PageTableSeeder` and updated related paths. Adjusted view components and layouts for streamlined coding practices and enhanced readability. Refactored migrations to update column naming and removed redundant indexing.
* Bump dependabot/fetch-metadata from 2.2.0 to 2.3.0

Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/dependabot/fetch-metadata/releases)
- [Commits](dependabot/fetch-metadata@v2.2.0...v2.3.0)

---
updated-dependencies:
- dependency-name: dependabot/fetch-metadata
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fix styling

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@thejmitchener thejmitchener merged commit 485b3c7 into main Feb 8, 2025
@thejmitchener thejmitchener deleted the tweak-blade-views-factory-seeder-and-provider branch February 8, 2025 19:37
fuelviews-app bot pushed a commit that referenced this pull request Feb 8, 2025
* Refactor: Seeder, views, and migrations for consistency

Replaced `PagesTableSeeder` with `PageTableSeeder` and updated related paths. Adjusted view components and layouts for streamlined coding practices and enhanced readability. Refactored migrations to update column naming and removed redundant indexing.

* Fix styling

* Bump dependabot/fetch-metadata from 2.2.0 to 2.3.0 (#27)

* Bump dependabot/fetch-metadata from 2.2.0 to 2.3.0

Bumps [dependabot/fetch-metadata](https://github.com/dependabot/fetch-metadata) from 2.2.0 to 2.3.0.
- [Release notes](https://github.com/dependabot/fetch-metadata/releases)
- [Commits](dependabot/fetch-metadata@v2.2.0...v2.3.0)

---
updated-dependencies:
- dependency-name: dependabot/fetch-metadata
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Fix styling

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix styling

* Fix styling

* Fix styling

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant