Refactored the GitHub workflow to run only if the actor is not Depend…

…abot. Updated the return type of the method in the class to use the constants for success and failure. (#46) * Refactored the GitHub workflow to run only if the actor is not Dependabot. Updated the return type of the method in the class to use the constants for success and failure. * Fix styling --------- Co-authored-by: thejmitchener <[email protected]>
fuelviews · Dec 18, 2024 · ad43985 · ad43985
1 parent 29ad4da
commit ad43985
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/open-ai-pr-description.yml b/.github/workflows/open-ai-pr-description.yml
@@ -15,7 +15,7 @@ jobs:
   openai-pr-description:
     runs-on: ubuntu-22.04
     # Run the job only if the actor is NOT Dependabot
-    if: ${{ !startsWith(github.actor, 'dependabot') }
+    if: ${{ !startsWith(github.actor, 'dependabot') }}
     steps:
       - uses: platisd/openai-pr-description@master
         with:

diff --git a/src/Commands/SitemapGenerateCommand.php b/src/Commands/SitemapGenerateCommand.php
@@ -15,6 +15,7 @@
 use Spatie\Sitemap\SitemapGenerator;
 use Spatie\Sitemap\SitemapIndex;
 use Spatie\Sitemap\Tags\Url;
+use Symfony\Component\Console\Command\Command as CommandAlias;
 
 class SitemapGenerateCommand extends Command
 {
@@ -33,7 +34,7 @@ class SitemapGenerateCommand extends Command
      * and posts and then either create a sitemap index to include them or
      * directly generate a single sitemap.
      */
-    public function handle(): bool
+    public function handle(): int
     {
         $this->diskName = $this->getDiskName();
 
@@ -61,12 +62,12 @@ public function handle(): bool
 
             $this->info('Sitemap generated successfully.');
 
-            return true;
+            return CommandAlias::SUCCESS;
         } catch (Exception $e) {
             Log::error('Sitemap generation failed: '.$e->getMessage());
             $this->error('Sitemap generation failed: '.$e->getMessage());
 
-            return false;
+            return CommandAlias::FAILURE;
         }
     }