fix(disconnect): no credential means nothing to revoke — say nothing - #561
Merged
Conversation
Current connect and pull bindings have no server credential to revoke. Report revoke success or failure only for legacy credential-bearing state, while still stopping the engine and marking every binding disconnected locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pull- or connect-bootstrapped team under the no-auth model has no credential file and no credential id, yet
disconnectprinted "Revoking credential with server... failed." followed by security-flavoured advice about compromised devices. The revoke call had nothing to send; "failed" was expected-but-misreported. Found by the machine-two dogfood (run 3) and queued since.Now: when neither credential artifact exists, the revoke step is skipped silently — there is nothing to revoke, so there is nothing to report. Legacy credential-bearing state keeps the existing revoke success/failure reporting unchanged.
Regressions cover both bootstrap paths (connect and pull) asserting no phantom warning appears.
PR opened on the author's behalf — their sandbox blocks GitHub access.