release(app): 0.4.0, bundling core v1.1.12 - #577
Merged
Conversation
Version and core pin move together, in one commit, because splitting them is how 0.1.5 shipped with the app version left behind. MINOR rather than PATCH: the two app changes since app-v0.3.0 are both features - drag files onto a pane (#481) and WebGL terminal rendering (#446). bundle-core.sh resolves the new pin and bundles agmsg-core 1.1.12.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump for the app 0.4.0 release. Both halves of the version state in one PR, since splitting them is how 0.1.5 shipped with the app version left behind.
Why MINOR
Both app changes since
app-v0.3.0are features:94704fddrag files onto a pane to insert their path (feat(app): drag files onto a pane to insert their path #481)3f87d60render terminals via WebGL, attached only to the active pane (feat(app): render terminals via WebGL, attached only to the active pane #446)That is the whole scope —
git log app-v0.3.0..main -- app/returns exactly these two.Assertions
Re-ran the release checklist's version assertions after the edit:
v1.1.12exists on origin, so the pin resolves rather than pointing at a tag that has not landed yet.Verification
One note on the test run: the first attempt reported
145 passedwith one suite failing to load —@xterm/addon-webglwas missing from a stalenode_modules. It is declared inpackage.jsonand present in the lockfile, sopnpm install --frozen-lockfileresolved it; nothing in this PR caused it. Worth recording because the failing count still looked like a pass at a glance: 34 tests were hidden behind the load error.