Do not trim reads when both ends are clipped in consensus calling #1026
+88
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1026 +/- ##
==========================================
- Coverage 95.65% 95.63% -0.02%
==========================================
Files 126 126
Lines 7403 7405 +2
Branches 521 499 -22
==========================================
+ Hits 7081 7082 +1
- Misses 322 323 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nh13
changed the title
nh13
commented
Feb 6, 2025
| case true if rec.end >= mateEnd => | ||
| case true if rec.end >= mateEnd => | ||
| // account for any soft-clipping on the same side of the template | ||
| val trailingClippedBases = if (rec.end == mateEnd) Math.min(rec.cigar.trailingClippedBases, rec.mateCigar.get.trailingClippedBases) else 0 |
There was a problem hiding this comment.
I think this is wrong, mate unclipped end should be used...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.