Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SamSource.query should handle out of range queries #1028

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: SamSource.query should handle out of range queries #1028

wants to merge 5 commits into from

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Feb 14, 2025

Fixes #943

@nh13 nh13 temporarily deployed to github-actions February 14, 2025 21:40 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions February 14, 2025 21:40 — with GitHub Actions Inactive
@codecov Codecov
Copy link

codecov bot commented Feb 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.65%. Comparing base (f93fdfb) to head (f1bfc36).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1028   +/-   ##
=======================================
  Coverage   95.65%   95.65%           
=======================================
  Files         126      126           
  Lines        7403     7407    +4     
  Branches      521      493   -28     
=======================================
+ Hits         7081     7085    +4     
  Misses        322      322
Flag Coverage Δ
unittests 95.65% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nh13 nh13 marked this pull request as ready for review February 14, 2025 21:50
@nh13 nh13 requested a review from tfenne as a code owner February 14, 2025 21:50
@nh13 nh13 requested a review from clintval February 14, 2025 21:50
@nh13
Copy link
Member Author

nh13 commented Feb 14, 2025

@clintval would you be able to take a quick peek?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfenne tfenne Awaiting requested review from tfenne tfenne is a code owner

@clintval clintval Awaiting requested review from clintval

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SamReader.query() should handle when coordinates are given < 1 or > end of contig
1 participant
@nh13