Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace output with spawn to prevent rofi from hanging while opening workspace #21

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Replace output with spawn to prevent rofi from hanging while opening workspace #21

merged 1 commit into from
Nov 12, 2024

Conversation

ShyAssassin
Copy link
Contributor

@ShyAssassin ShyAssassin commented Nov 11, 2024 •
edited
Loading

This PR changes all occurrences of output with spawn, this change prevents rofi from hanging while it waits for the vscode window open.

@fuljo fuljo merged commit d96e875 into fuljo:main Nov 12, 2024
3 checks passed
@fuljo
Copy link
Owner

fuljo commented Nov 12, 2024

Hi @ShyAssassin, that's a really good idea, indeed.
I've merged the change and released it as version 0.7.0.

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShyAssassin @fuljo