Skip to content

Conversation

@alnutile
Copy link

I would like to use it but outside of a module. Pulling it into another modules library. Also to help for easier testing outside of drupal.

@stewsnooze
Copy link
Member

Could you have done a git mv when migrating the entity_decorator.module file to EntityDecorator.php It is hard to see apart from just moving the other classes out what you've changed in the class.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst this is valuable. I wouldn't put it at the top of the file. I think it is important to explain what the software is before installation instructions and technical details like packagist

@stewsnooze
Copy link
Member

A few comments above.

We have sites running in production that we'd like to try running this with them.

However, what a wonderful addition to the software!

@alnutile
Copy link
Author

Oy super sorry about that! I was multitasking which never works well.

Alfred Nutile

On Jun 24, 2014, at 3:43 PM, Stewart Robinson [email protected] wrote:

Could you have done a git mv when migrating the entity_decorator.module file to EntityDecorator.php It is hard to see apart from just moving the other classes out what you've changed in the class.


Reply to this email directly or view it on GitHub.

@alnutile
Copy link
Author

If I get time I will write some phpunit tests. But thanks for your efforts on this! Coming from Rails and Laravel I miss this type of syntax.

Alfred Nutile

On Jun 24, 2014, at 3:48 PM, Stewart Robinson [email protected] wrote:

A few comments above.

We have sites running in production that we'd like to try running this with them.

However, what a wonderful addition to the software!


Reply to this email directly or view it on GitHub.

@njt1982
Copy link
Member

njt1982 commented Oct 30, 2014

Need master merged in..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants