fix(#107): add gitlint rule for forbidden type+scope combos#119
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#107): add gitlint rule for forbidden type+scope combos#119fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add a custom gitlint LineRule (UL1) that rejects commits using forbidden type(scope) combinations from COMMITS.md: fix(ci), feat(ci), fix(e2e), feat(e2e). Register the rule directory via extra-path in .gitlint so it runs in both the pre-commit hook and the commit-lint CI job. Add a test script (gitlint-forbidden-type-scope-test.sh) that validates the rule rejects all four forbidden combinations (including with breaking-change markers) and accepts valid type(scope) pairs like ci(pipeline), chore(ci), fix(#123). Note: pre-commit could not run in the sandbox (shellcheck-py install blocked by network policy, exit code 3). The post-script runs an authoritative pre-commit on the runner. Closes #107
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a custom gitlint LineRule (UL1) that rejects commits using forbidden type(scope) combinations from COMMITS.md: fix(ci), feat(ci), fix(e2e), feat(e2e). Register the rule directory via extra-path in .gitlint so it runs in both the pre-commit hook and the commit-lint CI job.
Add a test script (gitlint-forbidden-type-scope-test.sh) that validates the rule rejects all four forbidden combinations (including with breaking-change markers) and accepts valid type(scope) pairs like ci(pipeline), chore(ci), fix(#123).
Note: pre-commit could not run in the sandbox (shellcheck-py install blocked by network policy, exit code 3). The post-script runs an authoritative pre-commit on the runner.
Closes #107
Post-script verification
agent/107-add-forbidden-type-scope-rule)8fb64a25b70e4d364f6d535bb252c1bad521629d..HEAD)