fix(#120): resolve scribe schema from validation_loop#124
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#120): resolve scribe schema from validation_loop#124fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add schema: schemas/scribe-result.schema.json to the validation_loop block in harness/scribe.yaml, matching the pattern used by triage, code, and review harnesses. Remove the hardcoded FULLSEND_OUTPUT_SCHEMA env var from env.runner — the engine sets this automatically from validation_loop.schema. Without this fix, removing the .fullsend customized overlay leaves FULLSEND_OUTPUT_SCHEMA pointing at a missing file, causing validate-output-schema.sh to fail. Note: pre-commit could not run (shellcheck-py install failed due to sandbox network restrictions, exit code 3). Post-triage and post-scribe tests have pre-existing failures unrelated to this change. Closes #120
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add schema: schemas/scribe-result.schema.json to the validation_loop block in harness/scribe.yaml, matching the pattern used by triage, code, and review harnesses.
Remove the hardcoded FULLSEND_OUTPUT_SCHEMA env var from env.runner — the engine sets this automatically from validation_loop.schema.
Without this fix, removing the .fullsend customized overlay leaves FULLSEND_OUTPUT_SCHEMA pointing at a missing file, causing validate-output-schema.sh to fail.
Note: pre-commit could not run (shellcheck-py install failed due to sandbox network restrictions, exit code 3). Post-triage and post-scribe tests have pre-existing failures unrelated to this change.
Closes #120
Post-script verification
agent/120-fix-scribe-schema-resolution)8fb64a25b70e4d364f6d535bb252c1bad521629d..HEAD)