Skip to content

feat(agents): add action-hints footer to review, triage, and fix comments #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rh-hemartin wants to merge 1 commit into
base: main
Choose a base branch
from
+690 −2
Open

feat(agents): add action-hints footer to review, triage, and fix comments #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,6 @@ script-test:
$(call run-timed,bash scripts/post-scribe-test.sh)
$(call run-timed,bash scripts/validate-output-schema-test.sh)
$(call run-timed,bash .github/scripts/check-e2e-authorization-test.sh)
$(call run-timed,python3 scripts/process-fix-result-test.py)

test: script-test
4 changes: 4 additions & 0 deletions scripts/post-triage-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,10 @@ run_test "sufficient-with-info-gaps-fails" \
"" \
"true"

run_test "sufficient-appends-action-hints-footer" \
'{"action":"sufficient","reasoning":"all clear","clarity_scores":{"symptom":0.9,"cause":0.85,"reproduction":0.9,"impact":0.8,"overall":0.87},"triage_summary":{"title":"Fix crash on save","severity":"high","category":"bug","problem":"Crash","root_cause_hypothesis":"Buffer overflow","reproduction_steps":["step 1"],"environment":"Linux","impact":"All users","recommended_fix":"Fix buffer","proposed_test_case":"test_save_crash"},"comment":"## Triage Summary\n\nThis is ready."}' \
"/fs-code"

run_test "sufficient-removes-blocked-label" \
'{"action":"sufficient","reasoning":"all clear","clarity_scores":{"symptom":0.9,"cause":0.85,"reproduction":0.9,"impact":0.8,"overall":0.87},"triage_summary":{"title":"Fix crash on save","severity":"high","category":"bug","problem":"Crash","root_cause_hypothesis":"Buffer overflow","reproduction_steps":["step 1"],"environment":"Linux","impact":"All users","recommended_fix":"Fix buffer","proposed_test_case":"test_save_crash","information_gaps":[]},"comment":"## Triage Summary\n\nThis is ready."}' \
"gh api repos/test-org/test-repo/issues/42/labels/blocked -X DELETE --silent"
Expand Down
11 changes: 11 additions & 0 deletions scripts/post-triage.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,17 @@ if [[ -n "${DEFERRED_LABEL}" ]]; then
add_label "${DEFERRED_LABEL}"
fi

# --- Append action-hints footer (sufficient only) ---

if [[ "${ACTION}" == "sufficient" ]]; then
COMMENT="${COMMENT}

---
**Next steps:**
- \`/fs-code\` — agent creates a PR to implement this issue
- \`/fs-code <your instruction>\` — agent implements with your specific guidance"
fi

# --- Post comment ---

echo "Posting comment..."
Expand Down
Loading
Loading