Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added attribute for Hide Id #123

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

added attribute for Hide Id #123

wants to merge 17 commits into from

Conversation

xlogex
Copy link
Contributor

@xlogex xlogex commented Feb 9, 2022

No description provided.

xlogex and others added 17 commits January 29, 2022 17:03
Bumps [Blazored.LocalStorage](https://github.com/Blazored/LocalStorage) from 4.1.5 to 4.2.0.
- [Release notes](https://github.com/Blazored/LocalStorage/releases)
- [Commits](Blazored/LocalStorage@v4.1.5...v4.2.0)

---
updated-dependencies:
- dependency-name: Blazored.LocalStorage
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [MudBlazor](https://github.com/MudBlazor/MudBlazor) from 6.0.5 to 6.0.6.
- [Release notes](https://github.com/MudBlazor/MudBlazor/releases)
- [Changelog](https://github.com/MudBlazor/MudBlazor/blob/dev/CHANGELOG.md)
- [Commits](MudBlazor/MudBlazor@v6.0.5...v6.0.6)

---
updated-dependencies:
- dependency-name: MudBlazor
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…rage-4.2.0

Bump Blazored.LocalStorage from 4.1.5 to 4.2.0
Copy link
Contributor

@274188A 274188A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance you could do a squash?

@fretje
Copy link
Contributor

fretje commented Feb 10, 2022

I would actually not put the ID on there at all... especially the way it is now with <MudItem xs="12" md="6"> we're really limiting what can be done in the rest of the EditFormContent.

If a user of the table wants to show the id in there somewhere, he can put it in the EditFormContent himself. I would simply get rid of it here.

@xlogex
Copy link
Contributor Author

xlogex commented Feb 10, 2022

I proposed this feature because as information is not very useful to the common user.
but also the opportunity to view it in case serves

@fretje
Copy link
Contributor

fretje commented Feb 10, 2022

Yes, exactly as I am saying... it's not useful in most of cases, and when you really want it, you can still add it in the EditFormContent yourself... so still "the opportunity to view" ;-)

And this would mean a lot less code and complexity in the addeditform...

@xlogex
Copy link
Contributor Author

xlogex commented Feb 10, 2022

I understood, then would you like to eliminate it directly from the default template?

@fretje
Copy link
Contributor

fretje commented Feb 10, 2022

Yes, that's what I mean... but that's just my opinion... @iammukeshm might think something else? Or anybody else? I was just opening the discussion here ;-)

I actually already removed it before in one of my commits... It has been put back in the mean time... not sure why.

@xlogex
Copy link
Contributor Author

xlogex commented Feb 10, 2022

Yes, that's what I mean... but that's just my opinion... @iammukeshm might think something else? Or anybody else? I was just opening the discussion here ;-)

I actually already removed it before in one of my commits... It has been put back in the mean time... not sure why.

A cute thing could be to have the visibility of the configurable fields (at least those in the list)

@274188A
Copy link
Contributor

274188A commented Feb 14, 2022

in my opinion this is adding unneeded complexity to achieve something that can quite easy be done manually (by removing the column in the view)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants