FullStackHero 10 .NET Starter Kit Release Merge #1152
+64,607
−54,964
Draft
Annotations
10 warnings
|
Build:
src/Modules/Identity/Modules.Identity/Services/SessionService.cs#L358
'string.Contains(string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'FSH.Modules.Identity.Services.SessionService.GetDeviceType(string)' with a call to 'string.Contains(string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
|
|
Build:
src/Modules/Identity/Modules.Identity/Services/SessionService.cs#L353
'string.Contains(string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'FSH.Modules.Identity.Services.SessionService.GetDeviceType(string)' with a call to 'string.Contains(string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
|
|
Build:
src/Modules/Identity/Modules.Identity/Services/SessionService.cs#L353
'string.Contains(string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'FSH.Modules.Identity.Services.SessionService.GetDeviceType(string)' with a call to 'string.Contains(string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
|
|
Build:
src/Modules/Identity/Modules.Identity/Services/SessionService.cs#L353
'string.Contains(string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'FSH.Modules.Identity.Services.SessionService.GetDeviceType(string)' with a call to 'string.Contains(string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
|
|
Build:
src/Modules/Identity/Modules.Identity/Services/SessionService.cs#L353
'string.Contains(string)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'FSH.Modules.Identity.Services.SessionService.GetDeviceType(string)' with a call to 'string.Contains(string, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307)
|
|
Build:
src/Modules/Identity/Modules.Identity/Features/v1/Users/FshUser.cs#L21
Change 'PasswordHistories' to be read-only by removing the property setter (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2227)
|
|
Build:
src/Modules/Identity/Modules.Identity/Features/v1/Groups/UpdateGroup/UpdateGroupEndpoint.cs#L29
Change 'List<string>' in 'UpdateGroupRequest.RoleIds' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
|
|
Build:
src/Modules/Identity/Modules.Identity/Features/v1/Groups/Group.cs#L24
Change 'GroupRoles' to be read-only by removing the property setter (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2227)
|
|
Build:
src/Modules/Identity/Modules.Identity/Features/v1/Groups/Group.cs#L25
Change 'UserGroups' to be read-only by removing the property setter (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2227)
|
|
Build:
src/Modules/Identity/Modules.Identity/Features/v1/Groups/AddUsersToGroup/AddUsersToGroupEndpoint.cs#L25
Change 'List<string>' in 'AddUsersRequest.UserIds' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
|
Loading