Merged
Conversation
|
🔗 배포된 storybook 주소: https://65f015a4aed45406385006ee-qoqeqispbc.chromatic.com/ |
Leejin-Yang
approved these changes
Jun 13, 2024
|
|
||
| export type CategoryVariant = 'food' | 'store'; | ||
| export type MemberPostVariant = 'recipe' | 'review'; | ||
| export type TabVariant = CategoryVariant | MemberPostVariant; |
hae-on
pushed a commit
that referenced
this pull request
Nov 23, 2025
hae-on
added a commit
that referenced
this pull request
Nov 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
✨ 구현한 기능
TabMenu의 any를 제거했습니다.
대신 as 생김 ㅎ
📢 논의하고 싶은 내용
Tab을 사용하는 곳이 늘어나면, 그만큼 common.ts의 TabVariant에 추가해야함 (= 범용성 떨어짐)
하지만 any를 없애는 것에 의의를 두었음.
더 좋은 해결 방법을 알면 알려주세요.
🎸 기타
�x
⏰ 일정