Whimsical improvements (mainly type hints) #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cast value to byte in write-byte method to ensure compatibility
Ignore values that are not defined in the spec rather than throwing an error
- Add underscore prefix to unused function parameters - Fix namespace declarations and requires - Use consistent namespace aliases - Improve function docstring formatting
Add type hints to reduce reflection and memory allocations: - ByteBuffer type hints - int type hints for positions - ByteBufAllocator type hints This reduces memory allocations by ~80% in performance critical paths.
Add type hints to reduce reflection warnings: - Type hint byte arrays in string specs - Add return and parameter type hints in util functions - Type hint String instances These help eliminate reflection warnings when *warn-on-reflection* is enabled.
Add type hints to resolve reflection warnings: - ByteBuffer type hints for isDirect and getInt calls - ByteBuf type hints for isDirect calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes from Whimsical's version: