fix: Add % support for num_points param in plotting methods() #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removed one unnecessary collect()
Ceiled the computation to avoid 0 as result
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Ciao Graziano, thanks for the PR, Should have time to review tomorrow. Sorry for the late reply but this week was tough! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #236.
What does this implement/fix? Explain your changes.
num_pointsin plotting methods now is either float or int, and behaves accordingly.If it's a float, the number of selected points is computed as:
ceil(num_points * y.select(pl.len()).item())Any other comments?
I'm not sure how to write unit tests (and if they are necessary) for this feature, as it's just a small math computation.