-
Notifications
You must be signed in to change notification settings - Fork 62
fix: Polars >=1.0 fixes, kindly provided by tjader in https://github.… #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: Polars >=1.0 fixes, kindly provided by tjader in https://github.… #259
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… to old solution otherwise. (cherry picked from commit 99ecd1d)
(cherry picked from commit 6e8ab0c)
…dd test for date as well as datetime for fourier terms. (cherry picked from commit e96f0ac)
… sorting sets sorted_flag anyway, and 2 set_sorted only works on single column names. (cherry picked from commit 5aca64b)
… and remove redundant set_sorted. (cherry picked from commit c74eae9)
(cherry picked from commit f0eb8a5)
(cherry picked from commit 9c7afa0)
(cherry picked from commit b0d13af)
…zyFrame, but calling collect_schema() first.
…zyFrame, but calling collect_schema() first.
5b9b85c
to
ecb4a2a
Compare
Perhaps there is scope to fork this project and support the development with a fresh pypi package? |
Hi, Thanks for pushing the code and make it compatible with polars >= 1.0 I contacted @baggiponte and we are going to test this weekend and hopefully merge it by then. Keep posted 👍 |
Hello there, thanks @MathieuCayssol for the ping. Let's ship v0.9 with polars >=1 support. This review is going to take a bit of time since there's a lot to unpack. Python 3.9 support is reaching end of life this month but I think we should address this in a separate issue (although soon). Any opinions on this? Would it be too hard to decouple this PR from the 3.9 support? I see polars is still supporting py3.9. |
…com//pull/256
NOTE: this is only a slightly updated copy from the original PR - all credits go to the original author and the original PR
Reference Issues/PRs
What does this implement/fix? Explain your changes.
This PR fixes all issues with Polars >= 1.0 caught by existing tests.
Has been tested with Polars 1.8.2.
Any other comments?
All issues found were listed in polars' upgrade guide https://docs.pola.rs/releases/upgrade/1/, so versions of polars between 1.0 and 1.8.2 should be fine.