Skip to content

Conversation

fabianbergermann
Copy link

@fabianbergermann fabianbergermann commented Apr 21, 2025

…com//pull/256

NOTE: this is only a slightly updated copy from the original PR - all credits go to the original author and the original PR

Reference Issues/PRs

What does this implement/fix? Explain your changes.

This PR fixes all issues with Polars >= 1.0 caught by existing tests.

Has been tested with Polars 1.8.2.

Any other comments?

All issues found were listed in polars' upgrade guide https://docs.pola.rs/releases/upgrade/1/, so versions of polars between 1.0 and 1.8.2 should be fine.

Copy link

vercel bot commented Apr 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
functime-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2025 1:07pm

tjader and others added 12 commits April 21, 2025 13:34
… to old solution otherwise.

(cherry picked from commit 99ecd1d)
…dd test for date as well as datetime for fourier terms.

(cherry picked from commit e96f0ac)
… sorting sets sorted_flag anyway, and 2 set_sorted only works on single column names.

(cherry picked from commit 5aca64b)
… and remove redundant set_sorted.

(cherry picked from commit c74eae9)
(cherry picked from commit b0d13af)
@firmai
Copy link

firmai commented May 6, 2025

Perhaps there is scope to fork this project and support the development with a fresh pypi package?

sebbeutler pushed a commit to sebbeutler/functime that referenced this pull request May 26, 2025
@MathieuCayssol
Copy link
Collaborator

Hi,

Thanks for pushing the code and make it compatible with polars >= 1.0

I contacted @baggiponte and we are going to test this weekend and hopefully merge it by then.

Keep posted 👍

@baggiponte
Copy link
Collaborator

Hello there, thanks @MathieuCayssol for the ping. Let's ship v0.9 with polars >=1 support.

This review is going to take a bit of time since there's a lot to unpack.

Python 3.9 support is reaching end of life this month but I think we should address this in a separate issue (although soon). Any opinions on this? Would it be too hard to decouple this PR from the 3.9 support? I see polars is still supporting py3.9.

@baggiponte baggiponte mentioned this pull request Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants