Skip to content

Add cargo-shear to lint checks - #22

Open
Mshehu5 wants to merge 1 commit into
fungi-protocol:mainfrom
Mshehu5:shear
Open

Add cargo-shear to lint checks#22
Mshehu5 wants to merge 1 commit into
fungi-protocol:mainfrom
Mshehu5:shear

Conversation

@Mshehu5

@Mshehu5 Mshehu5 commented Jul 31, 2026

Copy link
Copy Markdown

Detect unused Rust dependencies with cargo-shear.
The check runs as part of the Nix lint suite and the tool is available in the development shell for local use.

@nothingmuch nothingmuch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK.

validate commits has an EXPECT-FAIL thing you can use to validate that this work: make a new commit with [EXPECT-FAIL: cargo-shear] in the title, cargo add an unnecessary dep, and validate-commits will ensure that the corresponding flake check fails.

i don't yet have infrastructure for this, the plan was to have these as commits that branch off the commit that introduces the flake check, and then maintain a "check-fixtures" branch or something like that which octo-merges those. then in the CI job, the octo merge can be used to find those commits, and each could be rebased on top of GITHUB_REF to ensure that the flake check has not regressed. for now i have been testing these locally where i've added them.

feel free to make this into a new issue if interested

@bc1cindy bc1cindy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK f12ae70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants