Add expected-failure fixture validation - #32
Draft
Mshehu5 wants to merge 1 commit into
Draft
Conversation
Add a check-fixtures registry runner that replays deliberately failing commits onto the target revision in temporary worktrees. Validate each fixture through the existing EXPECT-FAIL support in validate-commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24
Add infrastructure for replaying expected-failure check fixtures against the revision under test. The new Nix app discovers fixture commits from the check-fixtures registry branch, applies each fixture in a temporary worktree and uses the existing [EXPECT-FAIL: NAME] behavior in validate-commits to verify that the named Nix check rejects the deliberately bad change.
CI now fetches the fixture registry and validates every registered fixture.
Note for reviewers
The persistent check-fixtures branch must be created in the upstream repository before this PR is merged. Otherwise the new CI fetch step will fail because the registry branch does not exist.