Skip to content

Add scrubber bip - #12

Open
arminsabouri wants to merge 1 commit into
mainfrom
psbt-scruber
Open

Add scrubber bip#12
arminsabouri wants to merge 1 commit into
mainfrom
psbt-scruber

Conversation

@arminsabouri

Copy link
Copy Markdown
Collaborator

No description provided.

@xstoicunicornx

Copy link
Copy Markdown

Maybe put this in a "BIPs" folder? Since we also have concurrent psbt bip that would be good put in same folder.

@nothingmuch

Copy link
Copy Markdown
Contributor

Maybe put this in a "BIPs" folder? Since we also have concurrent psbt bip that would be good put in same folder.

i suggest bip-drafts, since they are not really bips until they are assigned a number in that repo

Comment thread bip-drafts/scrubber.md
Comment on lines +62 to +64
## Fields

We categorize PSBT fields from the [BIP 174 type registry](https://github.com/bitcoin/bips/blob/master/bip-0174/type-registry.mediawiki) by privacy sensitivity. Each table lists the registry name, key type, minimum PSBT version, and the BIP that introduces the field.

@nothingmuch nothingmuch Aug 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't address ordering, but i think it probably should

given that bip 174 already requires canonical compact int encoding i believe that apart from the ordering, there are no degrees of freedom in the psbt format itself that would result in serializer fingerprints

within each map, if all fields are sorted by type, and then keydata (already the case for psbt_v2 library's output)

if the maps are also sorted, then the output should become canonical

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorting section added. Thanks for pointing this out

@bc1cindy bc1cindy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concecpt ACK, great work!

Comment thread scrubber.md Outdated
Comment thread scrubber.md Outdated
Comment thread scrubber.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants