php 5.3 compatibility #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
in your README.md file you mention that "FUnit is a testing microframework for PHP 5.3+...". After using it to test my projects, i noticed that the methods throws and all_ok fail when using php 5.3 throwing the following error:
These two methods use the php type hint callable, which is available in php >= 5.4 (Callbacks / Callables).
Also, the unit tests do not work in php 5.3 because of the array dereference, also supported by php >= 5.4.
I' ve enabled the FUnit's methods throws and all_ok to accept any callables and also updated the unit tests in order to work with php 5.3.
Tell me what you think about it !