Open
Conversation
Contributor
|
👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Plasma (the material) is now called phoron. Most text in the game that mentions plasma by name is changed to reflect this. Plasma "gas" is referred to as "plasmic phoron" (or "plasma" or "phoron" depending on the context). Terms such as "plasmafire" and "plasma burn" are unchanged, as well as other contexts where "plasma" would make sense as referring to the state of matter (such as the popup for the result of making phlogiston).
Also I made a teeny tiny tweak to the name of the "water vapor gas miner" to just make it the "water vapor miner" to both keep it consistent with "phoron plasma miner" and avoid the weird psuedo-tautology that "vapor gas" is.
Why / Balance
Phoron was a name that some SS13 servers called the substance known as plasma on servers like /tg/station. When a lot of the core concepts of SS13 made its way over to SS14, "plasma" was the name that the team stuck with over "phoron" (though some references in the code to it remain, mainly in sprites brought over from SS13 servers that use the term).
I personally believe that "phoron" really sells the sci-fi wonder-material vibe it's going for (as opposed to... just the name of a state of matter that doesn't even apply to it in two out of the three states it can be in), and when I brought up this sentiment in #lore, a lot of other people in the community seemed to agree. I'm PRing this now rather than later because the sooner we commit to it, the easier it's going to be to maintain consistently.
Also I asked and @Gtheglorious said I could do it.
Technical details
FTL- and YAMLmaxxing.
Media
Requirements
License
MIT
Breaking changes
N/A.
Changelog
🆑