physics-simulation done #814

maharshi-gor · 2023-07-03T20:40:39Z

PR Details:

This PR has new changes for the physics-simulation section on the home page.

maharshi-gor · 2023-07-03T20:41:09Z

@tvcastillod @ganimtron-10 Please review this

ganimtron-10 · 2023-07-05T07:50:40Z

Hey @Mk996 would suggest you to directly add us as reviewers from the left hand side section called Reviews instead of commenting for the review!

maharshi-gor · 2023-07-05T14:32:22Z

Hey @Mk996 would suggest you to directly add us as reviewers from the left hand side section called Reviews instead of commenting for the review!

Hey @ganimtron-10, so I didn't have access to it. I just got it now will take care from the next PRs

skoudoro

LGTM, thanks @Mk996.

See below my small comment, after that, it can be merged

skoudoro · 2023-07-05T15:03:23Z

docs/source/_templates/home.html

-                                    <div>
-                                        <a href="auto_examples/index.html#demos"><img src="https://github.com/fury-gl/fury-communication-assets/raw/main/helical_path.gif" alt="Helical path" align="middle"></a>
-                                    </div>
+                        <h6 class="tabs-info">With FURY, it becomes simple to produce multiple physics animations with ease.</h6>


This text is slightly too big in mobile version. Can you update this text during mobile version.

Also, it would be great to use the same font family as the other section (scientific domains, etc...)

Hi Serge, I have fixed the text size. But, the font family is the same, it is a matter of color and font-weight but let me take that and make it uniform across the section

JoaoDell · 2023-07-05T15:05:06Z

Hey @Mk996, I don't have much (almost none) practice with html and css, so I don't think I will be much effective reviewing your PRs, but will see what I can do 👍

codecov · 2023-07-05T21:12:14Z

Codecov Report

Merging #814 (e9ab759) into master (06bacaa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #814   +/-   ##
=======================================
  Coverage   84.33%   84.33%           
=======================================
  Files          44       44           
  Lines       10356    10356           
  Branches     1410     1410           
=======================================
  Hits         8734     8734           
  Misses       1252     1252           
  Partials      370      370

ganimtron-10 · 2023-07-07T16:35:23Z

Hey @Mk996 ,
Did you tried building it locally I am getting some errors while building it!

maharshi-gor · 2023-07-07T18:42:55Z

Jul 7, 2023

@ganimtron-10 Every new change is reflected upon re-building only. I have tested that on my system @skoudoro can you try once

ganimtron-10 · 2023-07-08T03:08:39Z

Then I think there is some issue with my system as I am getting URLError as mentioned below while fetching things.

urllib.error.URLError: <urlopen error [WinError 10060] A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond>

ganimtron-10

Hey @Mk996,
Thanks for this PR. I can confirm that the website building issue is totally on my local machine, not sure why I am unable to load rawgithubusercontent but the workaround we discussed in yesterday's meeting helped me in that.

Please have a look at the below comment, once done this PR is good to go!

ganimtron-10 · 2023-07-12T03:07:40Z

docs/source/_templates/home.html

+                        <h6 class="tabs-info txt-center">With FURY, it becomes simple to produce multiple physics animations with ease.</h6>
+                        <div class="visualization-images">
+                            <div class="image-grid grid g-gap-2 g-col-3 g-row-2 g-m-col-2 g-m-row-3">
+                                <div>
+                                    <a href="fury-pybullet.html"><img
+                                            src="https://raw.githubusercontent.com/fury-gl/fury-communication-assets/main/physics_domino.gif"
+                                            alt="physics domino" align="middle"></a>
+
+                                </div>
+                                <div>
+                                    <a href="fury-pybullet.html"><img
+                                            src="https://raw.githubusercontent.com/fury-gl/fury-communication-assets/main/physics_bricks_multi_actor.gif"
+                                            alt="physics bricks" align="middle"></a>
+
+                                </div>
+                                <div>
+                                    <a href="fury-pybullet.html"><img
+                                            src="https://raw.githubusercontent.com/fury-gl/fury-communication-assets/main/physics_collision.gif"
+                                            alt="physic collision" align="middle"></a>
+
+                                </div>
+                                <div>
+                                    <a href="auto_examples/index.html#demos"><img
+                                            src="https://github.com/fury-gl/fury-communication-assets/raw/main/brownian_motion.gif"
+                                            alt="brownian motion" align="middle"></a>
+
+                                </div>
+                                <div>
+                                    <a href="auto_examples/index.html#demos"><img
+                                            src="https://github.com/fury-gl/fury-communication-assets/raw/main/em_wave.gif" alt="Em wave"
+                                            align="middle"></a>
+
+                                </div>
+                                <div>
+                                    <a href="auto_examples/index.html#demos"><img
+                                            src="https://github.com/fury-gl/fury-communication-assets/raw/main/helical_path.gif"
+                                            alt="Helical path" align="middle"></a>
+
                                </div>


Why so, few links are using raw.githubusercontent and few directly linking to the fury-communication-assets?
Can't we use consistent links?

Also please have a look at Github permalinks it would help here!

I did not change any link from the existing code. If not I might need to see what to change.

Also, using the raw GitHub link would be a better option as the fury-communications-asset is meant for storing the assets.

We don't want to go around and create a permalink of the objects as they are hard to manage.

Yup, I also think raw GitHub links might help.
Let's see what @skoudoro has to say!

no need for permalink, we keep permalink only for code for now.

Otherwise, I am ok, for both version, they point to the same place.

ganimtron-10 · 2023-07-12T03:08:10Z

docs/source/_templates/home.html

+                                    <div>
+                                        <a href="fury-pybullet.html"><img
+                                                src="https://github.com/fury-gl/fury-communication-assets/raw/main/molecular_ribbons.gif"
+                                                alt="Molecular Ribbon" align="middle"></a>
+                                    </div>
+                                    <div>
+                                        <a href="fury-pybullet.html"><img
+                                                src="https://github.com/fury-gl/fury-communication-assets/raw/main/molecular_surface.gif"
+                                                alt="Molecular Surface" align="middle"></a>


same as above

This cannot be converted to raw user link or permalink as the size of the asset is too big

maharshi-gor · 2023-07-13T01:21:44Z

We might need to hold this PR till #820 gets merged as the new interface for the mobile version of the scientific domain also redirects to tutorial corresponding to the video played.

ganimtron-10 · 2023-07-13T02:52:31Z

Hey @skoudoro, This PR is almost ready please check this out!

skoudoro

All good, you just need to update some link @Mk996. #820 has been merged so I am just waiting for you to update those links and we can merge this PR.

Thanks !

skoudoro · 2023-07-26T18:01:40Z

ping @Mk996, Can you update some links, then we can merge this PR

…imulation

skoudoro

Thank you for the update. LGTM. merging

physics-simulation done

7aed374

skoudoro reviewed Jul 5, 2023

View reviewed changes

text bugs fixed

0499cf5

maharshi-gor requested a review from skoudoro July 5, 2023 20:19

maharshi-gor added 3 commits July 7, 2023 23:25

all sections done

6609de3

scientific-domain mobile view

57515a2

comments removed

94d5632

ganimtron-10 suggested changes Jul 12, 2023

View reviewed changes

links updated

43fe11b

skoudoro reviewed Jul 19, 2023

View reviewed changes

maharshi-gor added 2 commits July 27, 2023 21:27

Merge branch 'master' of github.com:Mk996/fury into feature/physics-s…

b9d55f1

…imulation

links fixed

e9ab759

skoudoro approved these changes Jul 29, 2023

View reviewed changes

skoudoro merged commit 0baaf03 into fury-gl:master Jul 29, 2023
21 of 30 checks passed

skoudoro added the type:Documentation label Jul 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

physics-simulation done #814

physics-simulation done #814

maharshi-gor commented Jul 3, 2023

maharshi-gor commented Jul 3, 2023

ganimtron-10 commented Jul 5, 2023

maharshi-gor commented Jul 5, 2023

skoudoro left a comment

skoudoro Jul 5, 2023

maharshi-gor Jul 5, 2023

JoaoDell commented Jul 5, 2023

codecov bot commented Jul 5, 2023 •

edited

Loading

ganimtron-10 commented Jul 7, 2023

maharshi-gor commented Jul 7, 2023

ganimtron-10 commented Jul 8, 2023 •

edited

Loading

ganimtron-10 left a comment

ganimtron-10 Jul 12, 2023 •

edited

Loading

maharshi-gor Jul 13, 2023

maharshi-gor Jul 13, 2023

ganimtron-10 Jul 13, 2023

skoudoro Jul 19, 2023

ganimtron-10 Jul 12, 2023

maharshi-gor Jul 13, 2023

maharshi-gor commented Jul 13, 2023

ganimtron-10 commented Jul 13, 2023

skoudoro left a comment

skoudoro commented Jul 26, 2023

skoudoro left a comment

physics-simulation done #814

physics-simulation done #814

Conversation

maharshi-gor commented Jul 3, 2023

maharshi-gor commented Jul 3, 2023

ganimtron-10 commented Jul 5, 2023

maharshi-gor commented Jul 5, 2023

skoudoro left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoaoDell commented Jul 5, 2023

codecov bot commented Jul 5, 2023 • edited Loading

Codecov Report

ganimtron-10 commented Jul 7, 2023

maharshi-gor commented Jul 7, 2023

ganimtron-10 commented Jul 8, 2023 • edited Loading

ganimtron-10 left a comment

Choose a reason for hiding this comment

ganimtron-10 Jul 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maharshi-gor commented Jul 13, 2023

ganimtron-10 commented Jul 13, 2023

skoudoro left a comment

Choose a reason for hiding this comment

skoudoro commented Jul 26, 2023

skoudoro left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 5, 2023 •

edited

Loading

ganimtron-10 commented Jul 8, 2023 •

edited

Loading

ganimtron-10 Jul 12, 2023 •

edited

Loading