Continuing glTF/PBR Implementation

[m-agour]

This PR is based on the previous work in PR #715 . Trying to improve the PBR-based glTF models rendering in FURY.

It's been some time since my last contribution, and I'm excited to jump back in.
Currently, the PBR materials are working but without Environmental lighting and reflection as in the screenshot below:

I propose merging this to establish a solid ground from which we move on with more advanced lighting for the PBR glTF models.

[pep8speaks]

Hello @m-agour, Thank you for updating!

• In the file fury/gltf.py:

Line 279:80: E501 line too long (84 > 79 characters)
Line 439:80: E501 line too long (84 > 79 characters)
Line 459:80: E501 line too long (80 > 79 characters)
Line 465:80: E501 line too long (84 > 79 characters)

• In the file fury/tests/test_gltf.py:

Line 188:80: E501 line too long (84 > 79 characters)
Line 189:80: E501 line too long (84 > 79 characters)
Line 190:80: E501 line too long (88 > 79 characters)

To test for issues locally, pip install flake8 and then run flake8 fury.

Comment last updated at 2024-06-11 19:32:34 UTC

[m-agour]

So, Tests are failing even though objects are being rendered, I suspect its because I modified the lightening so when it tests for a specific color it might not be there anymore. i.e. this duck produced by the test code triggers an error even though it seems fine.

[skoudoro]

Thank you for this @m-agour.

I will be able to look into this only after December 27. I will keep you updated.

Thanks again!

[m-agour]

Hello @skoudoro, please take your time. I'll keep enhancing this it and troubleshooting the tests meanwhile.
Happy holidays!

[codecov]

Codecov Report

Attention: Patch coverage is 54.32099% with 37 lines in your changes missing coverage. Please review.

Project coverage is 84.08%. Comparing base (b38afc1) to head (d326f75).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #854      +/-   ##
==========================================
- Coverage   84.37%   84.08%   -0.29%     
==========================================
  Files          44       44              
  Lines       10553    10620      +67     
  Branches     1432     1445      +13     
==========================================
+ Hits         8904     8930      +26     
- Misses       1270     1302      +32     
- Partials      379      388       +9     

Files	Coverage Δ
fury/gltf.py	76.08% <54.32%> (-3.50%)	⬇️

[skoudoro]

Hi @m-agour,

Can you fix the 2 CI's "Codespell" and "Code format" before starting the review. Maybe a rebase of this PR will be enought to fix it, I did not check. Thank you in advance

[m-agour]

Hi @skoudoro , I will rebase today and ping you after all tests pass