Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Pycodestyle errors in fury/actors/odf_slicer.py, fury/actors/peak.py, fury/actors/tensor.py, and fury/data/fetcher.py #877

Merged
merged 5 commits into from
Apr 23, 2024

Conversation

WassCodeur
Copy link
Member

This Pull Request corrects errors in fury/actors/odf_slicer.py, fury/actors/peak.py, fury/actors/tensor.py and fury/data/fetcher.py.

fix: #876

The following changes have been made:

Files: fury/actors/odf_slicer.py, fury/actors/peak.py and fury/data/fetcher.py
    White spaces correction
    error correction: E501 line too long

File fury/actors/tensor.py:
       error correction: W605 invalid escape sequence '\D'

Tests:

I've run some tests to make sure the changes haven't affected the way the code works.

Coding conventions:

I have followed PEP8 coding conventions in this Pull Request.

Acknowledgements:

I thank the project contributors for their work and time.

I hope this Pull Request will be useful and that it will be integrated into the project.

Please don't hesitate to ask me questions if you need further information.

I'm still doing my best to fix the other pycodestyle errors in the other files.

@pep8speaks
Copy link

pep8speaks commented Mar 30, 2024

Hello @WassCodeur, Thank you for updating!

Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, pip install flake8 and then run flake8 fury.

Comment last updated at 2024-04-23 15:09:56 UTC

@skoudoro
Copy link
Contributor

Hi @WassCodeur,

Thank you for doing this!

See above, there is still an issue: #877 (comment)

Please, can you fix it?

@WassCodeur
Copy link
Member Author

Sure

@skoudoro
Copy link
Contributor

Do you have an update on this ?

@WassCodeur
Copy link
Member Author

yes I'm working on it, and I'll push it soon

@skoudoro
Copy link
Contributor

LGTM, merging, Thanks @WassCodeur

@skoudoro skoudoro merged commit 14851c6 into fury-gl:master Apr 23, 2024
23 of 29 checks passed
@WassCodeur
Copy link
Member Author

@skoudoro Always here to contribute! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants