Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wass contributions #882

Closed
wants to merge 9 commits into from
Closed

Conversation

WassCodeur
Copy link
Member

Refactor animation code and fix imports [pycodestyle]

@pep8speaks
Copy link

Hello @WassCodeur, thank you for submitting the Pull Request!

Line 9:1: F401 'fury.window.ShowManager' imported but unused
Line 9:1: F401 'fury.window.Scene' imported but unused

To test for issues locally, pip install flake8 and then run flake8 fury.

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 84.43%. Comparing base (14851c6) to head (02c3265).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #882   +/-   ##
=======================================
  Coverage   84.43%   84.43%           
=======================================
  Files          44       44           
  Lines       10537    10537           
  Branches     1423     1423           
=======================================
  Hits         8897     8897           
  Misses       1266     1266           
  Partials      374      374           
Files Coverage Δ
fury/animation/helpers.py 92.00% <ø> (ø)
fury/animation/timeline.py 56.52% <66.66%> (ø)
fury/animation/animation.py 68.78% <77.77%> (ø)

@WassCodeur WassCodeur closed this Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants