Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RF: Add keyword arguments to module: data #900

Merged
merged 1 commit into from
Jul 14, 2024
Merged

RF: Add keyword arguments to module: data #900

merged 1 commit into from
Jul 14, 2024

Conversation

WassCodeur
Copy link
Member

  • apply warn_on_args_to_kwargs to the module data
  • update the unitest

@skoudoro
Copy link
Contributor

Can you rebase to fix the conflict ? thanks

@skoudoro
Copy link
Contributor

Hi @WassCodeur,

there are problem in your rebase, we see blog posts in PR, we should not. we should see just your changes. Can you update.

Also, can you squash your commit.

Thank you

@pep8speaks
Copy link

pep8speaks commented Jul 11, 2024 •
edited
Loading

Hello @WassCodeur, Thank you for updating!

Line 570:4: E131 continuation line unaligned for hanging indent
Line 570:13: E251 unexpected spaces around keyword / parameter equals

To test for issues locally, pip install flake8 and then run flake8 fury.

Comment last updated at 2024-07-13 16:51:46 UTC

skoudoro
skoudoro approved these changes Jul 14, 2024
View reviewed changes
Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @WassCodeur , merging

@skoudoro skoudoro merged commit 384a7b7 into fury-gl:master Jul 14, 2024
17 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skoudoro skoudoro skoudoro approved these changes

@itellaetxe itellaetxe Awaiting requested review from itellaetxe

@robinroy03 robinroy03 Awaiting requested review from robinroy03

@deka27 deka27 Awaiting requested review from deka27

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WassCodeur @skoudoro @pep8speaks