Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] GSoC week 4 and 5 #906

Merged
merged 4 commits into from
Jul 10, 2024
Merged

[DOC] GSoC week 4 and 5 #906

merged 4 commits into from
Jul 10, 2024

Conversation

robinroy03
Copy link
Member

No description provided.

itellaetxe
itellaetxe reviewed Jul 3, 2024
View reviewed changes
Copy link

@itellaetxe itellaetxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super productive weeks, as I see. Amazing job. I know barely nothing about LLMs, yet I understood your work well. Approving.

docs/source/posts/2024/2024-07-01-week-4-robin.rst Show resolved Hide resolved
docs/source/posts/2024/2024-07-01-week-4-robin.rst Show resolved Hide resolved
docs/source/posts/2024/2024-07-01-week-5-robin.rst Outdated Show resolved Hide resolved
docs/source/posts/2024/2024-07-01-week-5-robin.rst Show resolved Hide resolved
m-agour
m-agour reviewed Jul 7, 2024
View reviewed changes
Copy link
Contributor

@m-agour m-agour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @robinroy03 for these two blog posts they compile nd render almost perfectly. I found only two issues:

docs/source/posts/2024/2024-07-01-week-5-robin.rst Outdated Show resolved Hide resolved
docs/source/posts/2024/2024-07-01-week-4-robin.rst Outdated Show resolved Hide resolved
skoudoro
skoudoro approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will go ahead and merge this PR.

But in a new PR, Can you address this warning during doc generation:

/Users/skoudoro/devel/fury/docs/source/posts/2024/2024-07-01-week-5-robin.rst:28: WARNING: Lexing literal_block '{\n    "query": "Render a cube in fury",\n    "llm": "llama3-70b-8192",\n    "knn": "3",\n    "stream": False\n}' as "json" resulted in an error at token: 'F'. Retrying in relaxed mode.

thanks

@skoudoro skoudoro merged commit 6bcadf9 into fury-gl:master Jul 10, 2024
17 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-agour m-agour m-agour left review comments

@itellaetxe itellaetxe itellaetxe left review comments

@skoudoro skoudoro skoudoro approved these changes

@WassCodeur WassCodeur WassCodeur approved these changes

@deka27 deka27 deka27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@robinroy03 @skoudoro @m-agour @itellaetxe @WassCodeur @deka27