Fix: Replace setuptools.extern.packaging with direct packaging import #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skoudoro
requested changes
Jul 24, 2024
There was a problem hiding this comment.
Hi @WassCodeur , thank you for this update. See below my comment
fury/deprecator.py
Outdated
| @@ -19,7 +19,7 @@ | |||
| # packaging.version.parse is a third-party utility but is used by setuptools | |||
| # (so probably already installed) and is conformant to the current PEP 440. | |||
| # But just if it is not the case, we use distutils | |||
| packaging, have_pkg, _ = optional_package("setuptools.extern.packaging") | |||
| packaging, have_pkg, _ = optional_package("packaging") | |||
There was a problem hiding this comment.
Packaging is a mandatory package so you do not need optional_package function and you can import it directly.
Thank you for the future update!
There was a problem hiding this comment.
Hi @skoudoro
Thank you for your feedback. I'll take it into account in my next update.
- update deprecator.py to use packaging instead of optional_package
WassCodeur
force-pushed
the
fix-Deprecator-bug
branch
from
aa8937c
to
403ebb7
Compare
skoudoro
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR corrects a problem related to the use of
setuptools.extern.packaging, which is not standard and not recommended by setuptools. The problem occurs with versions of setuptools >= 71.0.3, causing an ImportError when deprecated components are called.Changes
setuptools.extern.packagingby direct import ofpackagingintodeprecator.py.Reason
The
setuptools.externmodule was removed in>=71.0.0versions of setuptools, causing import errors. By updating the import declaration to usepackaging, we ensure that FURY remains compatible.Tests
Fix issue #912