[DOC] wachiou's Google Summer of Code Final report #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skoudoro
requested changes
Aug 22, 2024
There was a problem hiding this comment.
Hi @WassCodeur,
I can not review, it is very far from being ready. let me know when you have a full version.
WassCodeur
force-pushed
the
gsoc-final-report
branch
from
c199577
to
eb728cc
Compare
deka27
reviewed
Aug 23, 2024
deka27
reviewed
Aug 23, 2024
deka27
reviewed
Aug 23, 2024
skoudoro
reviewed
Aug 23, 2024
There was a problem hiding this comment.
Hi @WassCodeur,
Overall , looks good. See below some easy comment sto fix
|
we are waiting for your review @itellaetxe @robinroy03 |
WassCodeur
force-pushed
the
gsoc-final-report
branch
from
eb728cc
to
34b6266
Compare
itellaetxe
approved these changes
Aug 24, 2024
There was a problem hiding this comment.
I carefully read through it a couple of times and I think it is ready to go, Wachiou.
Links look fine, structure is hyper clean and well structured. Explanations are concise and clear. The videos support the explanations, and helped me understand what you were saying better.
Thanks for the work, your reviews, your suggestions and your advice. A pleasure to have worked with you.
LGTM, approving.
robinroy03
approved these changes
Aug 24, 2024
WassCodeur
force-pushed
the
gsoc-final-report
branch
from
34b6266
to
db51e6d
Compare
skoudoro
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My GSOC 2024 final report