[error] String reference field initialized with new string storage.

fusionlanguage · Sep 21, 2024 · ef7574c · ef7574c
1 parent f7475f0
commit ef7574c
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 5 deletions.
diff --git a/Sema.fu b/Sema.fu
@@ -2261,7 +2261,7 @@ public class FuSema
 				if (field.Value != null) {
 					field.Value = VisitExpr(field.Value);
 					if (!field.IsAssignableStorage())
-						Coerce(field.Value, field.Type is FuArrayStorageType array ? array.GetElementType() : field.Type);
+						CoercePermanent(field.Value, field.Type is FuArrayStorageType array ? array.GetElementType() : field.Type);
 				}
 				break;
 			case FuMethod! method:

diff --git a/libfut.cpp b/libfut.cpp
@@ -6780,7 +6780,7 @@ void FuSema::resolveCode(FuClass * klass)
 				field->value = visitExpr(field->value);
 				if (!field->isAssignableStorage()) {
 					const FuArrayStorageType * array;
-					coerce(field->value.get(), (array = dynamic_cast<const FuArrayStorageType *>(field->type.get())) ? array->getElementType().get() : field->type.get());
+					coercePermanent(field->value.get(), (array = dynamic_cast<const FuArrayStorageType *>(field->type.get())) ? array->getElementType().get() : field->type.get());
 				}
 			}
 		}

diff --git a/libfut.cs b/libfut.cs
@@ -6876,7 +6876,7 @@ void ResolveCode(FuClass klass)
 					if (field.Value != null) {
 						field.Value = VisitExpr(field.Value);
 						if (!field.IsAssignableStorage())
-							Coerce(field.Value, field.Type is FuArrayStorageType array ? array.GetElementType() : field.Type);
+							CoercePermanent(field.Value, field.Type is FuArrayStorageType array ? array.GetElementType() : field.Type);
 					}
 					break;
 				case FuMethod method:

diff --git a/libfut.js b/libfut.js
@@ -7262,7 +7262,7 @@ export class FuSema
 					field.value = this.#visitExpr(field.value);
 					if (!field.isAssignableStorage()) {
 						let array;
-						this.#coerce(field.value, (array = field.type) instanceof FuArrayStorageType ? array.getElementType() : field.type);
+						this.#coercePermanent(field.value, (array = field.type) instanceof FuArrayStorageType ? array.getElementType() : field.type);
 					}
 				}
 			}

diff --git a/test/ObjectFieldInit.fu b/test/ObjectFieldInit.fu
@@ -2,9 +2,13 @@ public class Test
 {
 	int Foo = 42;
 
+	static int Init() => 5;
+
+	int Bar = Init();
+
 	public static bool Run()
 	{
 		Test() o;
-		return o.Foo == 42;
+		return o.Foo == 42 && o.Bar == 5;
 	}
 }
diff --git a/test/error/StringLeak.fu b/test/error/StringLeak.fu
@@ -17,6 +17,8 @@ public static class Test
 
 	public static string GetValue(Match match) => match.Value; //ERROR: New string must be assigned to 'string()'
 
+	string Field = "FOO".ToLower(); //ERROR: New string must be assigned to 'string()'
+
 	public static bool Run()
 	{
 		return true;