Skip to content

Commit

Permalink
PR status: ignore trusteddomainproject#170 and update comment for tru…
Browse files Browse the repository at this point in the history 
…steddomainproject#173
  • Loading branch information
@futatuki
futatuki committed Sep 30, 2024
1 parent 3a58543 commit 639425c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions UPSTREAM_PR_STATUS.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
166 ignored PR against master. Also mixture of unrelated changes
167 merged
168 merged
170 reserved Need to know how the function arc_set_cv() is used.
170 ignored arc_set_cv() is a setter function. This change would hide the true cause of invalid results.
171 reserved No good reason to merge it (not interested in)
173 reserved It seems there can be different policies about how it should be dealt, so it might need a configuration option.
173 reserved Discussing how it should be.
176 merged
177 merged
178 merged
Expand Down

3 comments on commit 639425c

@abeverley
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @futatuki - I'm interested in the comment above regarding trusteddomainproject#170 and arc_set_cv(). I'm wondering if you can make any comments you think necessary in that PR? It would be useful to have some feedback. Thanks.

@futatuki
Copy link
Owner Author

@futatuki futatuki commented on 639425c Oct 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason why I didn't make any comment in trusteddomainproject#170 is that the comment above is largely subjective and I don't have strong counterproposal.

In this case what is correct fix is largely owe the design policy and perhaps we can't confirm how do the project members think about it, so it can be differenct policies in forks. Actually arc_set_cv() is proposed to be extended in the comment in trusteddomainproject#173.

Also it is why I've started to maintain my own branch to use.

@abeverley
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @futatuki that makes sense. I just wanted to make sure that I hadn't missed something important.

Please sign in to comment.