Skip to content

Commit

Permalink
Merge pull request trusteddomainproject#234 from futatuki/issue233-fi…
Browse files Browse the repository at this point in the history
…x-results-ignored-sigs

FIx issue trusteddomainproject#233: use "dkim=policy" for the result of DKIM signature
which is marked as "ignore" by dkim_sig_ignore(), instead of
"dikim=fail".
  • Loading branch information
futatuki committed Dec 22, 2024
2 parents e5512c1 + bfad8e1 commit ac96b16
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions opendkim/opendkim.c
Original file line number Diff line number Diff line change
Expand Up @@ -10682,6 +10682,7 @@ dkimf_ar_all_sigs(char *hdr, size_t hdrlen, struct dkimf_dstring *tmpstr,

for (c = 0; c < nsigs; c++)
{
unsigned int sigflag;
dnssec = NULL;

memset(comment, '\0', sizeof comment);
Expand All @@ -10703,7 +10704,12 @@ dkimf_ar_all_sigs(char *hdr, size_t hdrlen, struct dkimf_dstring *tmpstr,
&ssl);
}

if ((dkim_sig_getflags(sigs[c]) & DKIM_SIGFLAG_PASSED) != 0 &&
sigflag = dkim_sig_getflags(sigs[c]);
if (sigflag & DKIM_SIGFLAG_IGNORE)
{
result = "policy";
}
else if ((sigflag & DKIM_SIGFLAG_PASSED) != 0 &&
dkim_sig_getbh(sigs[c]) == DKIM_SIGBH_MATCH)
{
result = "pass";
Expand All @@ -10727,8 +10733,8 @@ dkimf_ar_all_sigs(char *hdr, size_t hdrlen, struct dkimf_dstring *tmpstr,
" reason=\"%s\"", err);
}
}
else if ((dkim_sig_getflags(sigs[c]) & DKIM_SIGFLAG_PROCESSED) != 0 &&
((dkim_sig_getflags(sigs[c]) & DKIM_SIGFLAG_PASSED) == 0 ||
else if ((sigflag & DKIM_SIGFLAG_PROCESSED) != 0 &&
((sigflag & DKIM_SIGFLAG_PASSED) == 0 ||
dkim_sig_getbh(sigs[c]) != DKIM_SIGBH_MATCH))
{
const char *err;
Expand Down

0 comments on commit ac96b16

Please sign in to comment.