Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add name field to flat configs #380

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

fbontin
Copy link
Contributor

@fbontin fbontin commented Nov 25, 2024

This should fix #375, let me know if I should change the names.

I'm not sure if there's anything else I should do, in that case please let me know :-)

Copy link

changeset-bot bot commented Nov 25, 2024

🦋 Changeset detected

Latest commit: 46d578c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-vue-scoped-css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

Could you please add the name to the base config as well?

https://github.com/future-architect/eslint-plugin-vue-scoped-css/blob/master/lib/configs/flat/base.ts

@fbontin
Copy link
Contributor Author

fbontin commented Nov 26, 2024

Thank you for this PR!

Could you please add the name to the base config as well?

https://github.com/future-architect/eslint-plugin-vue-scoped-css/blob/master/lib/configs/flat/base.ts

Yes, no worries, I added name for the two parts of the base config, let me know if they make sense. I'm not sure if there's a naming convention for these, so I guessed a bit :-)

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 37f5e17 into future-architect:master Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'name' field to configs
2 participants